chore: remove redundant :type annotations from docstrings#196
Open
Rotzbua wants to merge 1 commit intoweb-push-libs:mainfrom
Open
chore: remove redundant :type annotations from docstrings#196Rotzbua wants to merge 1 commit intoweb-push-libs:mainfrom
Rotzbua wants to merge 1 commit intoweb-push-libs:mainfrom
Conversation
Kept all mismatches for potential future fixes.
There was a problem hiding this comment.
Pull request overview
Removes redundant :type ...: fields from docstrings in pywebpush/__init__.py, relying more on function annotations for parameter typing (per issue #27).
Changes:
- Removed multiple
:typedocstring entries for parameters already typed in function signatures. - Kept some
:typeentries where they appear to be mismatched or carry extra semantics (per PR description).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove redundant :type annotations from docstrings which are already defined in function.
Kept all mismatches for potential future fixes.
Testing
Run test.
Issue(s)
related to #27