Use modern typing (PEP 585/604) for annotations#194
Open
Rotzbua wants to merge 1 commit intoweb-push-libs:mainfrom
Open
Use modern typing (PEP 585/604) for annotations#194Rotzbua wants to merge 1 commit intoweb-push-libs:mainfrom
Rotzbua wants to merge 1 commit intoweb-push-libs:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes type annotations across pywebpush to use PEP 585 (dict[...]) and PEP 604 (X | Y) syntax, aligning the codebase with the project’s Python >= 3.10 requirement.
Changes:
- Replaced legacy
typing.Dict/typing.Unionannotations with built-in generics and|unions in library code. - Updated similar claim typing in tests to match modern annotation style.
- Minor docstring whitespace cleanup.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
pywebpush/__init__.py |
Migrates public API and internal method annotations to modern typing syntax. |
pywebpush/tests/test_webpush.py |
Updates test typing for VAPID claim dictionaries to modern syntax. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rotzbua
force-pushed
the
feat_modern_typing
branch
from
951c5c5 to
bca56fb
Compare
Rotzbua
force-pushed
the
feat_modern_typing
branch
from
bca56fb to
2cb3de0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate old typing to modern. E.g.
Dicttodict.Testing
Run test.
Issue(s)
related to #27