webdriver: Wait indefinitely with None timeout#57403
webdriver: Wait indefinitely with None timeout#57403servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom
None timeout#57403Conversation
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
9a5a717 to
4b2e89a
Compare
|
Would you like to check the test? @whimboo Chrome is passing but Firefox is failing them. But I think there's been something wrong with Firefox's promise handling before this: |
| assert_error(response, "script timeout") | ||
|
|
||
|
|
||
| def test_promise_resolve_timeout_none(session): |
There was a problem hiding this comment.
This test is exactly same as
wpt/webdriver/tests/classic/execute_script/promise.py
Lines 12 to 21 in c1f157a
setTimeout changed from 50 to 200.
But somehow Firefox is passing test_promise_resolve_delayed but failing test_promise_resolve_timeout_none?
There was a problem hiding this comment.
Maybe this is related to #57160 and other recently opened issues around promises.
Can this PR wait a bit until the others have been done?
There was a problem hiding this comment.
This has nothing to do with #57160 tho. The tests here are essentially same as existing ones.
So far for
Nonetimeout, we've treated it effectively as no wait which is wrong: #57332 (comment).This PR makes all
Nonetimeouts wait indefinitely. The funny part is, we somehow have only done it correctly forpageload: https://w3c.github.io/webdriver/#dfn-timeouts-configurationTesting: We add test for script execution with
Nonescript timeout.Reviewed in servo/servo#42184