Skip to content

Enable URLPattern tests in ShadowRealm #49323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ptomato wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable URLPattern tests in ShadowRealm #49323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions urlpattern/resources/urlpattern-compare-tests.tentative.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ function runTests(data) {
}

promise_test(async function() {
const response = await fetch('resources/urlpattern-compare-test-data.json');
const data = await response.json();
const data = await fetch_json('resources/urlpattern-compare-test-data.json');
runTests(data);
}, 'Loading data...');
3 changes: 1 addition & 2 deletions urlpattern/resources/urlpatterntests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@ function runTests(data) {
}

promise_test(async function() {
const response = await fetch('resources/urlpatterntestdata.json');
const data = await response.json();
const data = await fetch_json('resources/urlpatterntestdata.json');
runTests(data);
}, 'Loading data...');
2 changes: 1 addition & 1 deletion urlpattern/urlpattern-compare.tentative.any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// META: global=window,worker
// META: global=window,worker,shadowrealm-in-window,shadowrealm-in-shadowrealm,shadowrealm-in-dedicatedworker,shadowrealm-in-sharedworker
// META: script=resources/urlpattern-compare-tests.tentative.js
2 changes: 1 addition & 1 deletion urlpattern/urlpattern-compare.tentative.https.any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// META: global=window,worker
// META: global=window,worker,shadowrealm
// META: script=resources/urlpattern-compare-tests.tentative.js
2 changes: 1 addition & 1 deletion urlpattern/urlpattern-hasregexpgroups.any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// META: global=window,worker
// META: global=window,worker,shadowrealm
// META: script=resources/urlpattern-hasregexpgroups-tests.js
2 changes: 1 addition & 1 deletion urlpattern/urlpattern.any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// META: global=window,worker
// META: global=window,worker,shadowrealm-in-window,shadowrealm-in-shadowrealm,shadowrealm-in-dedicatedworker,shadowrealm-in-sharedworker
Copy link
Copy Markdown
Contributor

@jeremyroman jeremyroman Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do most of these specify shadowrealm but this one specifies this list instead? What is the difference?

Copy link
Copy Markdown

@sisidovski sisidovski Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So these are the subset of shadowrealm? Maybe it's better to set shadowrealm.

wpt/tools/manifest/sourcefile.py

Lines 100 to 106 in 2b8ebc2

"shadowrealm": {"longhand": {
"shadowrealm-in-window",
"shadowrealm-in-shadowrealm",
"shadowrealm-in-dedicatedworker",
"shadowrealm-in-sharedworker",
"shadowrealm-in-serviceworker",
"shadowrealm-in-audioworklet",

Copy link
Copy Markdown
Contributor Author

@ptomato ptomato Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left out shadowrealm-in-serviceworker and shadowrealm-in-audioworklet because service workers and audio worklets can only be created in an HTTPS context, so they'd be generated with .https. anyway, and then be duplicates of the ones generated from shadowrealm.https.any.js.

// META: script=resources/urlpatterntests.js
2 changes: 1 addition & 1 deletion urlpattern/urlpattern.https.any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// META: global=window,worker
// META: global=window,worker,shadowrealm
// META: script=resources/urlpatterntests.js