Does add right implementation to save gauge metrics#56
Open
nicacioliveira wants to merge 2 commits intoweaveworks:masterfrom
Open
Does add right implementation to save gauge metrics#56nicacioliveira wants to merge 2 commits intoweaveworks:masterfrom
nicacioliveira wants to merge 2 commits intoweaveworks:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code, append the right way to save gauge metrics in the aggregation gateway.
This solution was developed in this repository, and all credits are of this guy.
We really need this implementation to save correctly gauge metrics and this is a good feature to have on this tool.