Open
Conversation
bboreham
reviewed
Feb 4, 2020
Contributor
bboreham
left a comment
bboreham
left a comment
There was a problem hiding this comment.
Thanks! One question about a change that looks unrelated/unnecessary.
Comment on lines
+215
to
+219
| // Sort labels in case source sends them inconsistently | ||
| for _, m := range family.Metric { | ||
| sort.Sort(byName(m.Label)) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
What's the reason to move this code?
Author
There was a problem hiding this comment.
The idea was to keep the validation first before doing actual work
Contributor
|
Ok that should be in a separate commit, probably a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading the documentation, we can expect that sending "Summary metrics" will be discard as the documentation explain:
It was collected and calling
/metricsreturns an error:https://github.com/weaveworks/prom-aggregation-gateway/blob/master/cmd/prom-aggregation-gateway/main.go#L223