Migrated to Jetty 7.x (via ring-jetty-adapter 1.1.8).#6
Open
duckyuck wants to merge 1 commit intoweavejester:masterfrom
duckyuck:jetty-7.x
Open
Migrated to Jetty 7.x (via ring-jetty-adapter 1.1.8).#6duckyuck wants to merge 1 commit intoweavejester:masterfrom duckyuck:jetty-7.x
duckyuck wants to merge 1 commit intoweavejester:masterfrom
duckyuck:jetty-7.x
Conversation
Author
|
Just noticed there is an issue regarding this already. #5 |
Owner
|
ring-serve is being deprecated in favor of ring-server, and swank-clojure is being replaced by nrepl.el, so I'm uncertain whether I should be updating ring-serve and therefore encouraging its use. |
Author
|
Agreed. Maybe add a deprecation notice in the README.md and link to ring-server? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi James.
This obviously breaks compatibility with Jetty < 6.x. You might want to bump the major (at least minor) release number of ring-serve due to this.
If you'd rather see a pull request which supports both 7.x and 6.x of Jetty I'll be happy to do so.
Regards,
Anders