-
Notifications
You must be signed in to change notification settings - Fork 85
Support clojure-based migrations #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Up for debate:
|
|
Thanks for the PR! To answer your questions:
|
|
Thanks for the review! 2- That was my original inclination, so great! I'll also address the lint warning I introduced. |
|
Ok @weavejester, I think I am ready for another review. |
|
When you find some time @weavejester, I'd be happy to hear what you think. |
|
Hi @weavejester! I am still happy to help bring this one to completion, if you find some time/interest. |
|
Apologies for the delay, this looks okay. Can you ensure any lines you added are 80 characters or less in length, and then squash your commits down. Then it should be good to merge. |
|
Thanks, @weavejester. I've addressed the 80-character line length feedback for changed lines. I will squash commits for you after I see CI passing for this commit. |
|
@weavejester, if you approve this workflow, we can witness it passing, then I can squash my commits as requested. |
|
Ah, sorry, the workflow button wasn't showing up earlier, so I assumed it had already run. |
ecc4f04 to
23a8e24
Compare
|
No problem, @weavejester. Commits are now squashed. |
|
Thanks for the PR and apologies for the delays in getting it merged. |
|
Hi @weavejester, what do you think about cutting a release? |
|
0.12.0 released. Apologies for the delay. |
|
Thanks @weavejester! |
Closes #162
Closes #164