This repository was archived by the owner on Feb 3, 2022. It is now read-only.
Refactor to use oauth2 gem and proper OAuth patterns #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6
reviewed
Mar 18, 2018
| class Configuration | ||
| REQUIRED_ATTRIBUTES = [:env, :api_version, :client_id] | ||
| ATTRIBUTES = [:client_secret, :auth] + REQUIRED_ATTRIBUTES | ||
| REQUIRED_ATTRIBUTES = [:env, :api_version, :client_id, :client_secret] |
Member
There was a problem hiding this comment.
Is there no case where client_secret would be optional? (for ruby integrations)
Author
There was a problem hiding this comment.
Not unless they wanted to use Implicit or Password.
For Implicit it makes no sense to use as that's less privileged than Authorization Code.
For Password we want to steer people away from that and will likely remove it from our API offering
|
Hi, is there an ETA for this? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forces Authorization Code or Client Credential flows only as a ruby gem will almost always use these modes.