Conversation
Contributor
|
This looks reasonable. I did some templated tests e.g. in test_fft, but without using the googletest support - I just called a templated test method from different TEST annotated calls. This scales better to more than two tests, even if the syntax isn't the most elegant thing. |
Contributor
Author
|
I don't mean to say it's ready for review, I'm just wondering whether the Draft status is why the CI didn't run. Or maybe that's a consequence of the rename of the main branch.... |
Contributor
|
I guess CI config is one thing the github feature does not do yet... |
Actually, my goal was to include tests for complex numbers, but that doesn't appear to be as straightforward as I was hoping...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly to see what the CI says, since I think this isn't ready for primetime.
I think fundamentally, typed tests are a good way to avoid duplication. My original goal was to specialize tests, for
float,double,gt::complex<float>, etc., but that hit some early obstacles (which need more looking at, and probably should be fixed.)So I went ahead with the other thing I was thinking to do, ie., generating tests for
gt::space::hostandgt::space::device. And while this works with CUDA, I think the way it is now, it assumes that device arrays can be initialized and accessed on the host, which we probably don't want to depend on in general (ie., without thrust).But so it also is actually a good starting point for a discussion on how to have an easy interface for writing gtensor code that can be compiled into gpu or cpu code transparently.