Merged
Conversation
germasch
approved these changes
Nov 13, 2025
Contributor
germasch
left a comment
germasch
left a comment
There was a problem hiding this comment.
This looks good to me. It kinda looks like some CI jobs are hanging, so if they don't go through eventually, ping me.
Contributor
|
CUDA still only needs 14 I think, but I have no objection to always requiring 17 - that would also allow us to simplify some code going forward. |
Contributor
|
Tests are hanging because ubuntu-20.04 is not available any more. I will work on a PR that updates the CI to use newer version, might have to remove some of the older compiler versions |
needed for rocm/7, so use always
Contributor
|
I rebased on the merged CI fix, hopefully will pass now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to c++17 always as is needed for rocm/7 (rocmprim)