Open
Conversation
ckkok
reviewed
May 31, 2018
| // return userInput + "th"; | ||
| // } | ||
|
|
||
| // console.log(ordinalSuffix(userInput)); |
Contributor
There was a problem hiding this comment.
Just a comment since I noticed you used multiple if statements here, and elsewhere you've used if-else statements... what made you choose multiple if statements over if-else statements here?
ckkok
reviewed
May 31, 2018
| // var randomNumber = Math.floor(Math.random()*11) | ||
|
|
||
| // var enteredNumber = prompt("Enter a whole number between 1 to 10"); | ||
|
|
Contributor
There was a problem hiding this comment.
Gotta be careful... randomNumber here goes from 0 to 10, so if it does end up being 0, poor user....
ckkok
reviewed
May 31, 2018
|
|
||
| // var testArray = [1, 2, 4, 8, 16, 32, 64, 128]; | ||
| // testArray = shuffle(testArray); | ||
| // console.log(testArray); |
Contributor
There was a problem hiding this comment.
I like how your variable names make sense to read as opposed to x, y, i, j, k!
ckkok
reviewed
May 31, 2018
| // Phonebook[addPhonebookName] = addPhonebookNumber; | ||
| // console.log("The number has been added!"); | ||
| // } | ||
| // } |
Contributor
There was a problem hiding this comment.
This loop actually inserts the entry into the phonebook multiple times since the comparison is nearly always false. Luckily Phonebook[addPhonebookName] always refers to the same entry so we don't get multiple entries...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.