Open
Conversation
ckkok
reviewed
May 31, 2018
|
|
||
|
|
||
| var result = userNumOne - userNumTwo; | ||
| console.log(result); |
Contributor
There was a problem hiding this comment.
But this gives -1 if userNumOne is 1 and userNumTwo is 2, when the difference should be 1... Maybe a if-else statement is needed here to carry out an extra step if the initial result is negative?
ckkok
reviewed
May 31, 2018
|
|
||
|
|
||
| var ordinalNum = parseInt(prompt("Provide a number", "0")); | ||
| var NumSplit = ordinalNum.split(""); |
Contributor
There was a problem hiding this comment.
Line 44 throws an error. The .split() method works on strings, but not integers, while in line 43, you've made sure that ordinalNum is an integer...
Author
There was a problem hiding this comment.
Would it be better to just prompt the user input as a string in order to split it better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.