Fix name of mimetype file and class #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's mimetype, not "minetype", and the file should have no extension. See: https://www.w3.org/publishing/epub3/epub-ocf.html#sec-zip-container-mime
|
Thanks @girzel for this, saved me a modicum of work :-) I've grabbed you change into my branch https://github.com/clach04/pypub/tree/main (trying to clean up a bunch of fixed into one place). |
|
Cross reference for complete mimetype fix #25 |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the mimetype file should be "mimetype", not "minetype", and the file should have no extension.
See:
https://www.w3.org/publishing/epub3/epub-ocf.html#sec-zip-container-mime
I haven't changed this in the MANIFEST file, because it says not to edit it. I also haven't changed it in the test output Epub file, as it seems like that file shouldn't be part of the repository at all, as it's an artifact of the test suite.
Anyway, I guess I'm surprised the epubs were validating, with a bogus mimetype file!