Migrate of the short-card component & Import connections from milo libs#1
Open
redvelvet511 wants to merge 2 commits intomainfrom
Open
Migrate of the short-card component & Import connections from milo libs#1redvelvet511 wants to merge 2 commits intomainfrom
redvelvet511 wants to merge 2 commits intomainfrom
Conversation
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
|
|
|
|
feat(short-card): import getMetadata directly feat(section-metadata): remove feat(getMetadata): export from libs
williambsm
force-pushed
the
shortcard-migration
branch
from
f69efd0 to
2b55458
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a test link:
https://shortcard-migration--adobestock--wbstry.hlx.page/drafts/sandra/test
The short-card variant is now available on Adobestock as a short card block