Skip to content

Remove mw 1.39 routing mapping #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dati18 merged 2 commits into from
Dec 19, 2025
Merged

Remove mw 1.39 routing mapping #1026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01107f8
Remove mw 1.39 routing mapping
dati18 Dec 19, 2025
1273b95
Update testResolverRoutesToCorrectHost
dati18 Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config/mw-db-version-map.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

// TODO: Read from outside of this codebase so that MW updates do not require code changes here.
$versionMap = [
'mw1.39-wbs1' => '139',
'mw1.43-wbs1' => '143',
];

Expand Down
6 changes: 3 additions & 3 deletions tests/Services/MediaWikiHostResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ class MediaWikiHostResolverTest extends TestCase {

public function testResolverRoutesToCorrectHost(): void {
$domain = (new Factory)->create()->unique()->text(30);
$this->createWiki($domain, 'mw1.39-wbs1');
$this->createWiki($domain, 'mw1.43-wbs1');
$resolver = new MediaWikiHostResolver;
$this->assertEquals(
'mediawiki-139-app-backend.default.svc.cluster.local',
'mediawiki-143-app-backend.default.svc.cluster.local',
$resolver->getBackendHostForDomain($domain)
);
}
Expand All @@ -37,7 +37,7 @@ private function createWiki(string $domain, string $version) {

public function testResolverThrowsIfUnableToFindHostInMap(): void {
$domain = (new Factory)->create()->unique()->text(30);
$this->createWiki($domain, 'mw1.39-unmapped');
$this->createWiki($domain, 'mw1.43-unmapped');
$resolver = new MediaWikiHostResolver;
$this->assertThrows(
fn () => $resolver->getBackendHostForDomain($domain),
Expand Down
Loading