update forked version to match #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zero is difficult
Changing many many files would often cause the browser to refresh rapidly, closing websockets before we had a chance to use them. This code causes us to wait until change events have idled for 200ms before sending the reload command, and filter for only open socket connections.
Better formatting for the graphic generation steps, including details on text imports for client-side JS.
Leftover headless processes were sticking around on Windows. Will need to test on a Mac.
Fixes weird broken embeds when loading a graphic without the trailing slash (since the parent loads the child as a relative URL to the basename, the server ends up treating the filename as the slug).
added 12 commits
March 22, 2021 14:20
This isn't a perfect fix--missing folders with no templates can still be bad, but those are easier errors to figure out.
This edge case was more trouble than it was worth to handle
Turns out this was confusing when getting Daniel Wheaton set up, since the intro page doesn't trigger an authorize redirect
Counterintuitively, this allows us to support import/export from ES modules. Fixes #47 and should (theoretically) allow us to upgrade D3.
Lots of comments, additional README files in the server directory
* start to merge in chalkbeat browserify -> rollup changes via Chalkbeat#2 * update babel/preset-env version * add geojson require support via b78bdb1
for when we want to sync to stage
fixes smartypants bug; closes #64
Minor clarifications
add a note about publishing google sheets to s3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.