Added calc_chisq method to fix issue with calculated chi2#63
Merged
wbalmer merged 5 commits intowbalmer:mainfrom May 21, 2025
Merged
Added calc_chisq method to fix issue with calculated chi2#63wbalmer merged 5 commits intowbalmer:mainfrom
wbalmer merged 5 commits intowbalmer:mainfrom
Conversation
This was referenced Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
median_chi2_redwas not correct because it was calculated from the likelihood function, which also contains the additive normalization term.I have added the
calc_chisqmethod, which is basically duplicatingloglike, so not an elegant solution.loglikeis used by the nested sampler so should only return the likelihood, therefore I could not quickly come up with a better solution.Note that
median_chi2_redis only shown in the plot, so the issue did not impact the fit.