Don't merge config if the config has been published#751
Open
keithbrink wants to merge 2 commits intowayofdev:masterfrom
Open
Don't merge config if the config has been published#751keithbrink wants to merge 2 commits intowayofdev:masterfrom
keithbrink wants to merge 2 commits intowayofdev:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lotyp
approved these changes
Aug 20, 2024
Author
|
@lotyp The failing tests don't seem like something that would have been affected by this change, do they? |
Member
First of all, I want to say thanks for your contribution to this project. 🔥 Regarding tests I will have a look as soon I can. Could be issue with permissions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 Changes Made
I added a condition to not run the mergeConfigFrom in the CycleServiceProvider if the config already has been published.
🤔 Rationale
If you do not have pdo_mysql installed (and likely the case with other pdo extensions), you will get an
Undefined constant PDO::MYSQL_ATTR_INIT_COMMANDerror, because the MysqlConfig class will get instantiated even if you remove it from the published config or set it to an empty value.📋 Checklist
make testpasses locally with my changesmake lintpasses locally with my changes - Invalid configuration errors🧪 Added or updated tests?