CMake: set compatibility to ExactVersion #274
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navganti
approved these changes
Mar 21, 2018
Member
navganti
left a comment
navganti
left a comment
There was a problem hiding this comment.
Good idea. So how do we specify this now when including wave into a project?
find_package(wave 0.1.0)?
Contributor
Author
|
Yes. It does potentially add a lot of work: if someone in a large monorepo project were to update the libwave submodule, modules may refuse to build until their CMakeLists are explicitly updated with the new libwave version. But it is more honest about our (lack of) compatibility guarantee. |
Member
|
I think that's fine for now @leokoppel. Plus this way the user will be more conscious about their libwave version and why they would like to use it. Better than everything breaking and the user getting mad at us :(. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are breaking API all the time due to development.
ExactVersion, meaning a dependee asking for libwave 0.1.0 will get an error if 0.1.1 or 0.2.0 is installed.Eventually we want to move to semantic versioning, but currently we are in what that standard calls the "initial development phase":
We should start incrementening the minor version.