Fix OceanDepthCache disabling in edit mode#897
Closed
magenta404 wants to merge 1 commit intomasterfrom
Closed
Conversation
Also use DefaultExecutionOrder
Collaborator
Author
|
This was half thought out so converted to draft. Numerous components use the pattern which disables itself in Start if no OceanRenderer is present. So maybe the other PR is also useful still. I'll strip this down to fixing the depth cache only. |
Contributor
|
Fwiw I approved 629, think I'd be in favour of merging that but you will know best. |
Collaborator
Author
Thanks. I won't merge it for this release as I would like to add some unit tests for that PR before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces #629.
The OceanDepthCache disabling itself in edit mode is the primary issue this PR addresses.
While #629 is a complete and robust solution, it is quite heavy for the three components that will use it:
Disabling the component only saves Update or PreRender from running and for these components which normally only have one it should be fine (OceanDepthCache disables after start anyway). Also, OceanDepthCache hard dependent on OceanRenderer as it falls back to the transform height.
Instead this makes it so dependent components execute after the OceanRenderer and leaves managing delayed initialisation to the user if they really need it. This is done with DefaultExecutionOrder attribute. It is the same thing as setting the execution order in the project settings, except they don't show up in the list. It can be overridden by the user if they add their own entry.
Let me know what you think.