Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![watermelon-copilot-for-code-review[bot]](https://avatars.githubusercontent.com/in/327523?s=60&v=4){kind=small}
utils/actions/detectConsoleLogs.ts
Outdated
| } | ||
| ) | ||
| .catch((err) => { | ||
| console.log(err); |
There was a problem hiding this comment.
This file contains at least one console log. Please remove any present.
| sgMail | ||
| .sendMultiple(msg) | ||
| .then(() => { | ||
| console.log("Email sent"); |
There was a problem hiding this comment.
This file contains at least one console log. Please remove any present.
There was a problem hiding this comment.
There you go! just fix this
There was a problem hiding this comment.
Uh so should it be sent to Posthog or...?
There was a problem hiding this comment.
Sounds like a plan, but don't be too strict about it.
WatermelonAI SummaryThis PR adds the ability to send a feedback email to users who uninstall the app. It includes changes such as adding catch statements, creating a GitHub PRs
Click here to login to Jira No results found in Notion Pages :( No results found in Linear Tickets :( Click here to login to Asana |
baristaGeek
left a comment
baristaGeek
left a comment
There was a problem hiding this comment.
I would've done this via Zapier, but it LGTM anyway. Just remove prod console logs and that's it
How does Zapier detect the team that uninstalled @baristaGeek ? |
I checked on Zapier and we can't trigger that event. I stand corrected. |
| sgMail | ||
| .sendMultiple(msg) | ||
| .then(() => { | ||
| console.log("Email sent"); |
There was a problem hiding this comment.
This file contains at least one console log. Please remove any present.
WatermelonAI SummaryThis PR titled "Feature/uninstall email" adds functionality to send a feedback email to users who uninstall the app. The commits in this PR include adding exception handling, creating a new file for sending the uninstall email, removing unused parameters, and extracting the action name. These changes enhance the user experience by providing a way to collect feedback from uninstalling users. GitHub PRs
Click here to login to Jira No results found in Notion Pages :( No results found in Linear Tickets :( Click here to login to Asana |
2 participants
Description
Sends a feedback email to users that uninstall the app
Type of change
Notes
Acceptance