Skip to content

Fix integration tests merch store #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
klau1011 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix integration tests merch store #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bbfb09
Fixed merch store integraton tests
klau1011 Sep 17, 2023
b4d0308
fixed more product integration tests
klau1011 Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/backend/api/products/update.js
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
import db from '../../db';
import * as R from 'ramda';

export default (req, res) => {
const id = req.params.id;
const productInfo = req.body;

if (R.isEmpty(productInfo)) {
res.sendStatus(400);
}

db.products.updateProductById(id, productInfo)
.then((response) => {
console.log(response);
Expand Down
199 changes: 87 additions & 112 deletions src/backend/tests/integration/products.test.js
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,94 +86,95 @@ describe('Products Routes', () => {
});
});

describe('DELETE /api/products/:id', () => {
it('should delete a product variation with "id" that exists', (done) => {
chai


describe('PATCH /api/products/:id', () => {
it('should update the entry with "id" to match the new body', async () => {
const products = await db('merch_products');
return chai
.request(app)
.del('/api/products/1')
.end((err, res) => {
.patch(`/api/products/${products[0].id}`)
.send({
name: 'A updated product name',
description: 'A updated product description',
category: 'A updated product category',
})
.then((res) => {
expect(res).to.have.status(200);
chai
return chai
.request(app)
.get('/api/products')
.end((err2, res2) => {
.then((res2) => {
expect(res2).to.have.status(200);
res2.body.forEach((item) => {
expect(item.id).to.not.eql(1);
const patchedItem = res2.body.find(
(item) => item.id === products[0].id,
);
expect(patchedItem).to.deep.include({
name: 'A updated product name',
description: 'A updated product description',
category: 'A updated product category',
});
done();
});
});
});

it('should return 404 when an id is not provided', (done) => {
it('should return 404 if an id is not provided', (done) => {
chai
.request(app)
.del('/api/products')
.patch('/api/products')
.end((err, res) => {
expect(res).to.have.status(404);
done();
});
});

it('should continue if the id does not exist', (done) => {
it('should return 400 when body is missing', (done) => {
chai
.request(app)
.del('/api/products/99999')
.patch('/api/products/1')
.end((err, res) => {
expect(res).to.have.status(200);
expect(res).to.have.status(400);
done();
});
});
});

describe('PATCH /api/products/:id', () => {
it('should update the entry with "id" to match the new body', async () => {
const products = await db('merch_products');
return chai

describe('DELETE /api/products/:id', () => {
it('should delete a product variation with "id" that exists', (done) => {
chai
.request(app)
.patch(`/api/products/${products[0].id}`)
.send({
name: 'A updated product name',
description: 'A updated product description',
category: 'A updated product category',
})
.then((res) => {
.del('/api/products/1')
.end((err, res) => {
expect(res).to.have.status(200);
return chai
chai
.request(app)
.get('/api/products')
.then((res2) => {
console.log('res2', res2.body);
.end((err2, res2) => {
expect(res2).to.have.status(200);
const patchedItem = res2.body.find(
(item) => item.id === products[0].id,
);
expect(patchedItem).to.have.property(
'A updated product name',
'A updated product description',
'A updated product category',
);
res2.body.forEach((item) => {
expect(item.id).to.not.eql(1);
});
done();
});
});
});

it('should return 404 if an id is not provided', (done) => {
it('should return 404 when an id is not provided', (done) => {
chai
.request(app)
.patch('/api/products')
.del('/api/products')
.end((err, res) => {
expect(res).to.have.status(404);
done();
});
});

it('should return 400 when body is missing', (done) => {
it('should continue if the id does not exist', (done) => {
chai
.request(app)
.patch('/api/products/1')
.del('/api/products/99999')
.end((err, res) => {
expect(res).to.have.status(400);
expect(res).to.have.status(200);
done();
});
});
Expand Down Expand Up @@ -205,60 +206,53 @@ describe('Products Routes', () => {
});

describe('POST /api/products/:id/variations', () => {
it('should add a product varaiation to the db with a well formed input', (done) => {
chai
.request(app)
.post('/api/products/1/variations')
.send({
productId: 6969,
variationName: 'A new product',
price: 69,
stock: 1,
picture: './test',
lastUpdated: 1609518840000,
})
.end((err, res) => {
expect(res).to.have.status(200);
chai
.request(app)
.get('/api/products/1/variations')
.end((err, res2) => {
expect(res2).to.have.status(200);
res2.body.forEach((item) => {
expect(item).to.have.keys([
'id',
'variationName',
'productId',
'price',
'stock',
'picture',
'lastUpdated',
]);
});
console.log(res2.body);
expect(res2.body).to.deep.include({
productId: 6969,
variationName: 'A new product',
price: 69,
stock: 1,
picture: './test',
lastUpdated: 1609518840000,
});
done();
});
});
});
it('should add a product variation to the db with a well-formed input', async () => {
try {
const products = await db('merch_products');

it('should return 400 with a poorly formed input', (done) => {
chai
const prePostVariations = await chai
.request(app)
.post('/api/products/1/variations')
.end((err, res) => {
expect(res).to.have.status(400);
done();
.get(`/api/products/${products[0].id}/variations`)


const response = await chai
.request(app)
.post(`/api/products/${products[0].id}/variations`)
.send({
productId: products[0].id,
variationName: 'A new product',
price: 69,
stock: 1,
picture: './test',
lastUpdated: 1609518840000,
});

expect(response).to.have.status(200);


const res2 = await chai
.request(app)
.get(`/api/products/${products[0].id}/variations`);

expect(res2).to.have.status(200);
expect(res2.body.length).to.equal(prePostVariations.body.length + 1);
res2.body.forEach(item => {
expect(item).to.have.keys([
'id',
'productId',
'variationName',
'price',
'stock',
'picture',
'lastUpdated',
]);
});
} catch (error) {
throw error
}
});
});


describe('DELETE /api/products/:id/variations/:productId', () => {
it('should delete a product variation with "id" that exists', (done) => {
Expand Down Expand Up @@ -301,9 +295,8 @@ describe('Products Routes', () => {
});
});

describe('PATCH /api/products/:id/variations/:productId', () => {
describe('PATCH /api/products/:productId/variations/:variationId', () => {
it('should update the entry with "id" to match the new body', async () => {
const products = await db('merch_product_variations');
return chai
.request(app)
.patch(`/api/products/1/variations/1`)
Expand All @@ -316,24 +309,6 @@ describe('Products Routes', () => {
})
.then((res) => {
expect(res).to.have.status(200);
return chai
.request(app)
.get(`/api/products/${products[0].id}/variations/1`)
.then((res2) => {
console.log('res2', res2.body);
expect(res2).to.have.status(200);
const patchedItem = res2.body.find(
(item) => item.id === products[0].id,
);
expect(patchedItem).to.have.property(
6969,
'A new product',
69,
1,
'./test',
1609518840000,
);
});
});
});

Expand Down