Port to FreeBSD#1120
Conversation
syrusakbary
requested review from
Hywan,
MarkMcCaskey,
bjfish,
losfair and
nlewycky
as code owners
nlewycky
left a comment
nlewycky
left a comment
There was a problem hiding this comment.
@syrusakbary, do we want a CI for freebsd to go with this?
| } | ||
|
|
||
| #[cfg(not(target_os = "macos"))] | ||
| // Linking to functions that are not provided by rust libc |
There was a problem hiding this comment.
Is this permanent? If not, I'd really appreciate it if this could include a link to an issue or PR.
There was a problem hiding this comment.
I can try to upstream the fn definition.
There is a PR for the ucontext/mcontext part rust-lang/libc#1630
| @@ -0,0 +1,127 @@ | |||
| # NOTE: Keep this consistent with `fault.rs`. | |||
There was a problem hiding this comment.
I checked it visually and it looks like it's a copy of the linux one. In your opinion should we just rename it to something like sysv-elf and use the same for both, or do you think there's something here that FreeBSD might change and need a different image loader for?
There was a problem hiding this comment.
Yes it's the same as the linux one. I think we can use the same for Linux/FreeBSD.
MarkMcCaskey
left a comment
MarkMcCaskey
left a comment
There was a problem hiding this comment.
This looks pretty good to me -- I'm super excited about this PR!
I agree with @nlewycky's comments though.
The stuff in emscripten is lower priority, but if parts of rust libc are missing then I think the right thing to do is to add them to Rust libc or at least file an issue and link to the issue in our code!
|
Hi, |
|
bors try |
|
edit: nevermind actually, there were changes to the |
|
aarch64 tests seem to be passing :) |
tryBuild failed
|
|
bors try |
tryBuild succeeded
|
|
bors r+ |
|
👎 Rejected by too few approved reviews |
MarkMcCaskey
left a comment
MarkMcCaskey
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks!!
|
bors r+ |
1120: Port to FreeBSD r=MarkMcCaskey a=syrusakbary <!-- Prior to submitting a PR, review the CONTRIBUTING.md document for recommendations on how to test: https://github.com/wasmerio/wasmer/blob/master/CONTRIBUTING.md#pull-requests --> # Description I disovered this great patch today: https://github.com/MikaelUrankar/webasm/blob/master/www/wasmer/files/patch-freebsd And then realized that @MikaelUrankar forked wasmer to add support for FreeBSD. I'm creating this PR to follow up on that fork and merge the changes upstream. @MikaelUrankar let us know if everything is good to go with this PR! <!-- Provide details regarding the change including motivation, links to related issues, and the context of the PR. --> # Review - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: MikaelUrankar <mikael.urankar@gmail.com>
Build succeeded
|
ghost
mentioned this pull request
4 participants
Description
I disovered this great patch today: https://github.com/MikaelUrankar/webasm/blob/master/www/wasmer/files/patch-freebsd
And then realized that @MikaelUrankar forked wasmer to add support for FreeBSD.
I'm creating this PR to follow up on that fork and merge the changes upstream.
@MikaelUrankar let us know if everything is good to go with this PR!
Review