Draft
Conversation
Author
Author
Ok, that is not realistic. In that case, I cannot update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Ok, the migration is almost ready. Running
cargo testin thecrates/gen-wasmerfolder passes. I cannot runcargo testin the root folder, because of some error with Python.But there is one last problem to solve ... how to resolve the imports. Currently, I am using a cloned version of wasmer. There is no change in the
wai-bindgen-wasmercrate in the wasmer repo other than changing thewai-bindgen-wasmer-impldependency to this for in the repo, like so:But how to resolve this? I guess I should check if the
data_and_store_mutmethod works in wasmer 3.1, at least then thegen-wasmercrate could be updated as a non-breaking change.But that still leaves to decide what to do with the
wasitowasix"migration". The new wasix crate is needed because it uses wasmer 3.3, but users who use wai bindgen with wasmer 3.1 would expirience a breaking change when updating wai-bindgen-wasmer, because it would create a conflict between wasmer 3.1 and 3.3I will have to look at it more tomorrow.