fix: avoid port collision in HttpServer tests #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricochet
force-pushed
the
test-listener
branch
4 times, most recently
from
50a8356 to
c96e2f8
Compare
Tests called find_available_port() which binds a TcpListener to port 0, reads the port, then drops the listener. Later, HttpServer::start() tries to re-bind that same port. Between the drop and re-bind, another test (running in parallel) can grab that port. HttpServer::new() binds the TcpListener eagerly and holds it. The socket stays open from construction through to start(), which takes ownership of the already-bound listener. The port is never released, so no other process or test can steal it. Tests just pass "127.0.0.1:0" to new() and call addr() to discover the port. Signed-off-by: Bailey Hayes <bailey@cosmonic.com>
ricochet
force-pushed
the
test-listener
branch
from
c96e2f8 to
5bb8811
Compare
lxfontes
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests called find_available_port() which binds a TcpListener to port 0,
reads the port, then drops the listener.
Later, HttpServer::start() tries to re-bind that same port.
Between the drop and re-bind, another test (running in parallel) can
grab that port.
HttpServer::new() binds the TcpListener eagerly and holds it. The socket
stays open from construction through to start(), which takes ownership
of the already-bound listener. The port is never released, so no other
process or test can steal it. Tests just pass "127.0.0.1:0" to new() and
call addr() to discover the port.