adds missing types, consts, and extern C refs for reading characters …#9
Conversation
|
When running
|
8cc8fdc to
9dd665c
Compare
Arshia001
left a comment
There was a problem hiding this comment.
Thanks for this contribution, @TheNotary!
I've mentioned a couple of things I think don't align with wasix-libc. Also, the changes need to be moved to src/wasi/wasix.mod, which is for WASIX-specific functionality. src/wasi/mod.rs is for functionality that's common between WASI preview 1 and WASIX.
…immediately from terminal
9dd665c to
8b91603
Compare
|
Thanks for the review, I've updated this PR. Could you link your reference for the remark regarding wasix-libc and |
…immediately from terminal
A rust POC that uses this patch can be found here: https://github.com/TheNotary/another-rust-terminal-app
Thanks for considering submitting a PR!
We have the
contribution guide.
Please read it if you're new here!
Here is a checklist for things that will be checked during review or continuous
integration:
libc-test/semverwhen you add/removeitem(s), e.g. edit
linux.txtif you add an item tosrc/unix/linux_like/linux/mod.rs*LASTor*MAX(see #3131)adds or changes API.
changes (otherwise a release could be delayed)
ci/style.shpassescd libc-test && cargo testand CI. Ignore local failures if you are not sure)
Delete this line and everything above before opening your PR.