Skip to content

adds missing types, consts, and extern C refs for reading characters …#9

Merged
Arshia001 merged 2 commits intowasix-org:wasix-0.2.169from
TheNotary:allow-basic-tcgetattr
Oct 16, 2025
Merged

adds missing types, consts, and extern C refs for reading characters …#9
Arshia001 merged 2 commits intowasix-org:wasix-0.2.169from
TheNotary:allow-basic-tcgetattr

Conversation

@TheNotary
Copy link

@TheNotary TheNotary commented Oct 7, 2025

…immediately from terminal

A rust POC that uses this patch can be found here: https://github.com/TheNotary/another-rust-terminal-app

Thanks for considering submitting a PR!

We have the
contribution guide.
Please read it if you're new here!

Here is a checklist for things that will be checked during review or continuous
integration:

  • Edit corresponding file(s) under libc-test/semver when you add/remove
    item(s), e.g. edit linux.txt if you add an item to
    src/unix/linux_like/linux/mod.rs
  • Your PR doesn't contain any private or unstable values like *LAST or
    *MAX (see #3131)
  • Provide a link to relevant source (headers or documentation) if your PR
    adds or changes API.
  • If your PR has a breaking change, please clarify it
  • If your PR increments version number, it must NOT contain any other
    changes (otherwise a release could be delayed)
  • Make sure ci/style.sh passes
  • cd libc-test && cargo test
    • (this might fail on your env due to environment difference between your env
      and CI. Ignore local failures if you are not sure)

Delete this line and everything above before opening your PR.

@TheNotary
Copy link
Author

When running cd libc-test; cargo test I get the below errors which I don't believe are related to this patch:

error: unnecessary parentheses around closure body
--> libc-test/build.rs:3210:33
|
3210 | cfg.skip_static(move |name| (name == "__dso_handle"));
| ^ ^
|
note: the lint level is defined here
--> libc-test/build.rs:1:9
|
1 | #![deny(warnings)]
| ^^^^^^^^
= note: #[deny(unused_parens)] implied by #[deny(warnings)]
help: remove these parentheses
|
3210 - cfg.skip_static(move |name| (name == "__dso_handle"));
3210 + cfg.skip_static(move |name| name == "__dso_handle");
|
error: could not compile libc-test (build script) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

@TheNotary TheNotary changed the base branch from master to wasix-0.2.169 October 8, 2025 03:13
@TheNotary TheNotary force-pushed the allow-basic-tcgetattr branch from 8cc8fdc to 9dd665c Compare October 8, 2025 03:20
Copy link

@Arshia001 Arshia001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution, @TheNotary!

I've mentioned a couple of things I think don't align with wasix-libc. Also, the changes need to be moved to src/wasi/wasix.mod, which is for WASIX-specific functionality. src/wasi/mod.rs is for functionality that's common between WASI preview 1 and WASIX.

@TheNotary TheNotary force-pushed the allow-basic-tcgetattr branch from 9dd665c to 8b91603 Compare October 8, 2025 13:22
@TheNotary
Copy link
Author

Thanks for the review, I've updated this PR. Could you link your reference for the remark regarding wasix-libc and typedef unsigned int speed_t;?

@TheNotary TheNotary requested a review from Arshia001 October 9, 2025 20:24
@Arshia001 Arshia001 merged commit c2063d1 into wasix-org:wasix-0.2.169 Oct 16, 2025
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants