Testing build fixes related to OSX#11
Closed
TheNotary wants to merge 9 commits intowasix-org:wasix-0.2.169from
Closed
Testing build fixes related to OSX#11TheNotary wants to merge 9 commits intowasix-org:wasix-0.2.169from
TheNotary wants to merge 9 commits intowasix-org:wasix-0.2.169from
Conversation
TheNotary
force-pushed
the
testing-build-fixes
branch
from
f3112f6 to
8405dda
Compare
Author
|
Closing this in favor of minimizing divergence from upstream by disabling unneeded tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are build error in Linux, Max and Windows that I noticed when drafting another PR.
General Rust Issues
Rust nightly's compiler is now insisting that
extern fnis no good and should be replaced withextern "C" fn.Use of the
s!macro meant==methods were being implemented for functions returning pointer functionsLinux
Linux was erroring with apt-get, because I presume the docker image we were building from was out of date and not an LTS version of Ubuntu.
Also there was apparently a Kernel update where the struct for
xdp_umem_regchanged. This might be a "breaking change," though I'm uncertain what the implications are of this change for existing consumers.Windows
It looks like Windows broke due to changes in it's kernel emulator thing, perhaps related to changes in
xdp_umem_reg? I didn't address the Windows build here, to make it easier to think through the Rust nightly and Linux Kernel changes.