Open
Conversation
And make OrderedCollection inherit from Collection
warriordog
reviewed
Oct 16, 2024
| /// <seealso href="https://www.w3.org/TR/activitystreams-vocabulary/#dfn-collection" /> | ||
| /// <seealso href="https://www.w3.org/TR/activitystreams-vocabulary/#dfn-orderedcollection" /> | ||
| public class ASOrderedCollection : ASObject, IASModel<ASOrderedCollection, ASOrderedCollectionEntity, ASObject>, IEnumerable<Linkable<ASObject>> | ||
| public class ASOrderedCollection : ASCollection, IASModel<ASOrderedCollection, ASOrderedCollectionEntity, ASCollection>, IEnumerable<Linkable<ASObject>> |
Owner
There was a problem hiding this comment.
this, unfortunately, won't work because ASCollection has a separate entity with a separate copy of the collection. It may be possible to support this by loading the same entity into both classes - I'll take a look into that.
Collaborator
Author
There was a problem hiding this comment.
It's not that big of a deal, honestly. I'll split out the shared inbox. The rest is workable as-is. The AS2 inheritance tree is nonsensical.
warriordog
reviewed
Oct 16, 2024
| /// <seealso href="https://www.w3.org/TR/activitystreams-vocabulary/#dfn-collection" /> | ||
| /// <seealso href="https://www.w3.org/TR/activitystreams-vocabulary/#dfn-orderedcollection" /> | ||
| public class ASOrderedCollection : ASObject, IASModel<ASOrderedCollection, ASOrderedCollectionEntity, ASObject>, IEnumerable<Linkable<ASObject>> | ||
| public class ASOrderedCollection : ASCollection, IASModel<ASOrderedCollection, ASOrderedCollectionEntity, ASCollection>, IEnumerable<Linkable<ASObject>> |
Owner
There was a problem hiding this comment.
it also breaks for ASOrderedCollectionPage, which should logically be assignable to both ASOrderedCollection and ASCollectionPage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And make OrderedCollection inherit from Collection
This just updates some types to more closely match the spec.