Fix defects overflow #451
Open
Fix defects overflow #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a defects file (.mrc) to mask out dead pixel of the detector, but I ran into a very strange issue when trying to use it. When I run the first processing steps to get averages of my tilt movies (fs_motion_and_ctf), it seems only part of the averages have the defects correctly masked out, and it seemed completely random which ones had it correct. And, every time I rerun, the corrected files seem to randomly change without any pattern.
I had Claude go over the codebase and after some back-and-forth it managed to propose this fix... which fixed it 👍 According to Claude it a GPU memory overflow issue and it caused the observed race condition.
@dtegunov let me know if this fix makes sense to you