-
Notifications
You must be signed in to change notification settings - Fork 16
added options to export ctf parameters as csv and subtomogram without ctf correction #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ut ctf correction
|
@alncat thanks for taking the time to propose a PR! I'm glad you've been able to use Warp outputs for your own work :-) Doesn't the yellow map (i.e. without new functionality) look better? Our goal when exporting particles has been compatibility with RELION. Non-CTF aware particle reconstruction introduces a way to misuse Warp for our users and I'm not sure I see the benefit right now... I'm very open to exporting CTF metadata if this is useful for you but would prefer that export happen via its own method on TiltSeries rather than an extra argument to the GetCTFs method |
|
@dtegunov would be good to understand your perspective on this kind of change, is this a thing we want/are okay with accepting? |
|
@alisterburt @dtegunov Thank you very much for your feedbacks and considering my PR! I kept the CTF corrected subtomogram as the default format for exporting. So this PR won't break the original compatibility with other softwares. I was aiming to export the per-particle CTF parameters, so i modified the GetCTFs method in which the CTFs are reconstructed. If you can give me a pointer to the method in TiltSeries, i am very happy to change it~ |
|
Hi @alisterburt, just checking in on the status of this PR. Please let me know if there's anything you need from my side. Thanks! |
|
Hi @alncat - sorry but it's not clear to me how to proceed here, I have to leave the decision to Dimitry |
|
@alisterburt Got it~ |
|
Hi @dtegunov , please let me know if there's anything you need from my side. Thank you for considering this PR! |
|
Thanks for the PR, @alncat! I'll have to give the CTF correction part more thought, but GetCTFsForOneParticle etc. are not a good place to be writing out files. You can get the parameters using TiltSeries.GetCTFParamsForOneTilt from outside the TiltSeries class and then write them out. @alisterburt I remember discussing plans for bringing back pre-Relion 5 style particle tilt series STAR files (i.e. a line for every particle tilt, including CTF parameters). Did we ever act on those plans? They would be equivalent to these CSVs and @alncat could just convert without modifying Warp. |
|
@dtegunov Thank you very much for reviewing it! I will check this method |
nah never got done, would be nice for 3DPCA too so I guess it could be done soon... |
that sounds great! |



Dear WARP/M developer,
I have implemented two new options to control the format of subtomograms exported by WARP.
The first option is
--output_ctf_csv, which will tell WARP to export ctf parameters for each subtomogram as a csv file. The name of csv file have the same prefix as the 3DCTF exported by WARP and is located at the same folder for the corresponding subtomogram.The second option is
--dont_correct_ctf_3d, which will tell WARP to export subtomogram without CTF correction. I added a conditionif (options.CorrectCTF)to toggle onwhen the argument
--dont_correct_ctf_3dis not enabled. In the backprojection step,the weight for each pixel in the images of tilt series is set to 1. The 3DCTF is reconstructed in a similar way.
Hence, when
--dont_correct_ctf_3dis specified, WARP will export subtomogram reconstructed by backprojecting raw images in tilt series.These options are useful for training OPUS-TOMO (https://github.com/alncat/opusTomo), which can often effectively identify target specie from initial particle picks in the initial stages of tomographic data processing. These modifications might be a useful addition to WARP's functions. Any feedbacks will be greatly appreciated!
Sincerely,
Zhenwei Luo