Feat/pack stickers #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Use standards-compliant commit messages https://www.conventionalcommits.org/en/v1.0.0/ |
billalxcode
requested changes
Jul 11, 2024
| public function index(Pack $pack) | ||
| { | ||
| // | ||
| return $pack->stickers; |
Collaborator
Author
There was a problem hiding this comment.
laravel is atuomaticly convert model to json response so it will return like thi
{
"image": <image_path>,
"pack_id": <pack_id>
}
source: link
Collaborator
There was a problem hiding this comment.
Please use the following format
- If successful
{"status": bool, "data": dict} - If it fails
{"status": bool, "message": string}
Collaborator
There was a problem hiding this comment.
Why do you have to follow the standards? because it will make it easier to process data
| public function update(Request $request, Sticker $sticker) | ||
| { | ||
| // | ||
| return $sticker; |
| * Remove the specified resource from storage. | ||
| */ | ||
| public function destroy(Sticker $sticker) | ||
| public function destroy(Pack $pack, Sticker $sticker) |
Collaborator
There was a problem hiding this comment.
Delete the pack variable if it is not used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.