fix: Check message function last to enable computed errors #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codinsonn
commented
Sep 22, 2023
Comment on lines
-44
to
+49
| if (typeof message === 'function') { | ||
| finalMessage = message(value, values, options) | ||
| } | ||
| if (typeof message !== 'undefined') { | ||
| finalMessage = message | ||
| } | ||
| if (typeof message === 'function') { | ||
| finalMessage = message(value, values, options) | ||
| } |
Author
There was a problem hiding this comment.
We need to check for the function type after checking for undefined, because otherwise, if it is a function:
- We'll compute the message first (good)
- We'll then also immediately overwrite that computed message with the message function (bad)
By reversing the order, we avoid this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.