Skip to content

[WIP] Refactor core module with logging and I/O improvements#4

Merged
t-koretsune merged 1 commit intorefactor/core-cleanupfrom
copilot/sub-pr-3
Jan 1, 2026
Merged

[WIP] Refactor core module with logging and I/O improvements#4
t-koretsune merged 1 commit intorefactor/core-cleanupfrom
copilot/sub-pr-3

Conversation

Copy link
Copy Markdown

Copilot AI commented Jan 1, 2026

  • Address deprecation warnings - replace np.fromstring with modern alternatives
  • Fix inconsistent logging format (use built-in parameter substitution)
  • Fix docstring formatting issues (return types, typos, grammar)
  • Improve error messages (replace assertions with descriptive ValueErrors, use f-strings consistently)
  • Add try-finally block for timer in wannierization loop
  • Fix validation logic using hasattr instead of getattr
  • Optimize memory usage in file parsing (avoid string concatenation)
  • Change generic Exception to ValueError for consistency

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI mentioned this pull request Jan 1, 2026
@t-koretsune t-koretsune marked this pull request as ready for review January 1, 2026 23:33
@t-koretsune t-koretsune merged commit 58d646c into refactor/core-cleanup Jan 1, 2026
1 check failed
Copilot AI requested a review from t-koretsune January 1, 2026 23:36
@t-koretsune t-koretsune deleted the copilot/sub-pr-3 branch January 5, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants