Skip to content

Conversation

@wambitz
Copy link
Owner

@wambitz wambitz commented Dec 15, 2025

Description

This pull request makes minor improvements to the development environment setup, specifically targeting the container configuration and Dockerfile.

  • Dev container setup:

    • Added a blank line for readability in .devcontainer/devcontainer.json.
  • Dockerfile update:

    • Updated the entrypoint script path to use scripts/docker/entrypoint.sh instead of scripts/entrypoint.sh for better organization.

@wambitz wambitz self-assigned this Dec 15, 2025
Copilot AI review requested due to automatic review settings December 15, 2025 05:37
@wambitz wambitz linked an issue Dec 15, 2025 that may be closed by this pull request
@wambitz wambitz merged commit 1b3b71b into main Dec 15, 2025
9 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a new entrypoint script for Docker container user remapping to improve development environment portability. The entrypoint script dynamically remaps the container user's UID/GID to match the host user's, preventing file permission issues when mounting volumes. The script is organized in the scripts/docker/ directory alongside other Docker-related utilities.

Key Changes:

  • Added scripts/docker/entrypoint.sh to handle runtime UID/GID remapping for the container user
  • Updated Dockerfile to reference the new script path at scripts/docker/entrypoint.sh
  • Added a blank line in .devcontainer/devcontainer.json for formatting

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
scripts/docker/entrypoint.sh New entrypoint script that remaps container user UID/GID to match host user, fixes ownership of home directory and workspace
Dockerfile Updated COPY command to reference the new entrypoint script location in scripts/docker/ directory
.devcontainer/devcontainer.json Added trailing blank line for formatting consistency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: relocate Docker entrypoint to scripts/docker/

2 participants