Marks strings as mutable in preparation for Ruby freezing strings#106
Open
radville wants to merge 3 commits intowallyqs:masterfrom
Open
Marks strings as mutable in preparation for Ruby freezing strings#106radville wants to merge 3 commits intowallyqs:masterfrom
radville wants to merge 3 commits intowallyqs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a deprecation warning for chilled strings merged recently in Ruby: ruby/ruby@12be40a
And with that we started to see the following warning coming from
org-ruby:This makes updates to freeze strings by default and mark others unfrozen where needed in order to maintain functionality with smallest changes possible.