Update test suite for new Ruby and Highlighting#103
Open
HParker wants to merge 1 commit intowallyqs:masterfrom
Open
Update test suite for new Ruby and Highlighting#103HParker wants to merge 1 commit intowallyqs:masterfrom
HParker wants to merge 1 commit intowallyqs:masterfrom
Conversation
This updates the test fixtures for the updated output highlighters like pigment gives on modern versions. It also removes the deprecated calls to `File.exists?`. These changes together get the test suite passing on modern Ruby versions with modern gems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the test fixtures for the updated output highlighters like pygment gives on modern versions. It also removes the deprecated calls to
File.exists?.These changes together get the test suite passing on modern Ruby versions with modern gems.
This partially duplicates the work in #101 by @graaff, so feel free to merge that PR and I can remove the
File.exists?part of this PR, but I include both otherwise tests tests are left failing.