WIP: Replace app icon #645
Conversation
|
Yay! So glad you're working on this. Should I close #638 in favor of this? |
|
Tested in Android 7.0. It looks good but I don't like the padding around the icon (in my xiaomi is white around the grey icon). |
|
I did and now I don't have a clear mind about that... |
|
I would love this PR merged with the padding. Debug icons?? |
|
@lokesh-krishna would it be possible for you to add a debug icon and create a PR against the branch test_icons ? @ all: What was the decision, which icons we use? Does Android documentation have a recommendation in this regard? Ones with padding or without? |
|
@Strubbl, I've provided a debug icon at #638. Will that PR not suffice? I will gladly make one against the branch you mentioned if that is the case. Information regarding padding for product icons can be found here: Material Design Guidelines. The relevant information is in the section titled "DP unit grid". I am not sure I understood it though so it would be nice if someone could go through it and explain what exactly it is saying. Also, there is mention of padding in the document regarding Implementing Adaptive Icons. The content I am talking about is at the very end of the page, in the "Known Issues" section. Does that apply to us and even if it doesn't presently, is it something we should be taking into consideration when it comes to padding? |
|
I prefer without padding, but it's only my opinion. |
|
Seeing how we could go with either, opinions are all that matter. Would love to somehow see what the consensus and merge one of them. |
|
are we waiting for something? |
|
I prefer the one without padding, which should integrate more easily in a multitude of launchers and custom icons pack. But I agree that either way this should be merged 😄 |
Icons with padding.
As I mentioned earlier, some icons have problems with aliasing.