Introduce builder and wrapper functions to simplify recipe logic #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace static `Items` utility with `ItemBuilder` and `WeaponBuilder` for more modular item creation. - Introduce `ConfigHelper` for centralized configuration access. - Implement `ItemModelData` for consistent handling of custom model data. - Create `RecipeRegistrar` to manage conditional recipe registration. - Refactor `Listeners` to leverage new utility classes and improve event handling logic. - Consolidate multiple smithing table event handlers into a single, more generic method. - Update various parts of the codebase to use the new, more modular components.
…I and add null checks Refactored internal builder API for recipes and listeners to improve stability and robustness. Key changes include: - Introduced `SmithingRecipeBuilder` to encapsulate smithing recipe creation logic, replacing the monolithic `handleSmithingEvent` method in `Listeners.java`. - Ensured `ItemBuilder` and `WeaponBuilder` constructors perform explicit runtime null checks for `Material` parameters using `Objects.requireNonNull`. - Corrected enchantment application logic in `RecipeProvider` methods to ensure enchantments are applied to the final `ItemStack` instance. - Added `Objects.requireNonNull` checks to constructors and critical method parameters in `RecipeProvider` and `RecipeRegistrar` for fail-fast behavior. - Improved dynamic attribute modifier handling in `SmithingRecipeBuilder`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.