Preserve rotation and positioning for diagonal ledge hangs#3
Draft
Preserve rotation and positioning for diagonal ledge hangs#3
Conversation
|
Download the built assets for this pull request: |
This reverts commit 6181116665fd3123c6fdf1c7cb676c8c0e5676c3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Lara_Col_IsDiagonalLedge(declared incol.hand implemented incol.c).EDGE_CATCH_POSfromLara_Col_TestEdgeCatchwhen applicable.Math_GetDirectionConetoMath_GetDirectionfor diagonal ledges and preserveitem->rot.y(instead of snapping toMath_DirectionToAngle) during jump and crawl to hang flows, and avoid sector-edge rounding by applyingcoll->shift.x/coll->shift.zdirectly for diagonal cases.climb.cto useMath_Sin/Math_Cos-based position shifts and allow diagonal slopes in the slope-difference check.Testing
Codex Task