feat: allow setting base64 encoded icon strings

[franklinkim]

Allow setting icon string directly:

waldur:
  whitelabeling:
    loginLogo: "<base64 encoded string>"
    sidebarLogo: "<base64 encoded string>"
    sidebarLogoDark: "<base64 encoded string>"
    poweredByLogo: "<base64 encoded string>"
    favicon: "<base64 encoded string>"
    heroImage: "<base64 encoded string>"

[livenson]

hi, we had this before but the drawback was the etcd limit of configmap of 1MB that was very hard to enforce then across all settings. Perhaps a different solution could work for you?

[franklinkim]

Of cause having the images in there is not really practically and you probably also want to be able to define urls here e.g. loginLogoURL. The main reason here, is that within the template you're using .Files.Get which can only access files within the Chart. Depending on the build system you might just reference it and take care yourself of providing the base64 encoded string from a file outside of the Chart.

[livenson]

Files.Get is tbh a legacy we are moving away from, are you relying on it?

[franklinkim]

nothing, we can't change :)

[livenson]

Sorry, didn't get it - if we remove loading of files with Files.Get , will this have any influence on you?

[franklinkim]

no, we'll adapt. i would be fine to specify an external http address instead of embedding it