Add openstreetmap to locations and Wrap blog tag filters in nav element for accessibility#639
Closed
Kkt04 wants to merge 2 commits intowagtail:mainfrom
Closed
Add openstreetmap to locations and Wrap blog tag filters in nav element for accessibility#639Kkt04 wants to merge 2 commits intowagtail:mainfrom
Kkt04 wants to merge 2 commits intowagtail:mainfrom
Conversation
Author
|
@thibaudcolas kindly review the PR and let me know if i need to make any changes |
Member
|
@Kkt04 👋 I’m not sure why you’re working on this? This was just a suggestion someone made and it’s not particularly well suited to this project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #625
Issue: Add OpenStreetMap embed to Location pages for geographic context (zero JavaScript, no API key required) and Wrap blog tag filters in nav element for accessibility
Changes Made:
bakerydemo/locations/models.pybakerydemo/templates/locations/location_page.htmlbakerydemo/templates/locations/locations_index_page.htmlbakerydemo/static/css/main.cssWhy this approach:
Also I edited the file bakerydemo/templates/blog/blog_index_page.html to wrap the blog tag filters in a
element for accessibility
Git Branch:
add-openstreetmap-to-locations