Refactor duplicated search markup into reusable template includes#634
Open
rajesh-puripanda wants to merge 2 commits intowagtail:mainfrom
Open
Refactor duplicated search markup into reusable template includes#634rajesh-puripanda wants to merge 2 commits intowagtail:mainfrom
rajesh-puripanda wants to merge 2 commits intowagtail:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While exploring the
bakerydemotemplates I noticed duplicated markup for the search form and search icon inheader.html.This PR extracts those sections into reusable template includes to reduce duplication and improve maintainability.
Changes
includes/search_icon_svg.htmlincludes/search_form.htmlheader.htmlwith{% include %}Result
Verification
python manage.py testHappy to adjust the approach if there's a preferred template pattern for this.