feat: add block-based footer menu using StreamField (refs #554)#632
Open
Raghaddahi wants to merge 1 commit intowagtail:mainfrom
Open
feat: add block-based footer menu using StreamField (refs #554)#632Raghaddahi wants to merge 1 commit intowagtail:mainfrom
Raghaddahi wants to merge 1 commit intowagtail:mainfrom
Conversation
Author
|
Hey @thibaudcolas, would love to get your review on this PR |
4546308 to
18f872e
Compare
Author
|
hey @cnk, could you pls rerun the workflows, i have fixed the failing one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a footer menu to the demo in addition to the existing footer text.
The footer menu adds a second level to the footer, consisting of sections where each section has a list of menu items and each menu item can be a link to a page, url or document.
Changes
Features
Testing
Tested by adding external URL, pages and document in the admin dashboard.
Before

After

AI Usage
Used Claude.ai to understand the existing codebase (FooterText model, navigation_tags.py) and to assist in writing footer_menu.html template. All code was reviewed by me.
Note
I implemented the footer menu first as mentioned in the issue. The main menu refactor I will refactor the main menu once I discus it with the team.