Merged
Conversation
asp345
force-pushed
the
feature/oci-migration
branch
3 times, most recently
from
15a4b1c to
4fc05b5
Compare
asp345
requested review from
Hank-Choi,
davin111 and
eastshine2741
and removed request for
a team
asp345
force-pushed
the
feature/oci-migration
branch
2 times, most recently
from
7cce6bd to
e90fd55
Compare
davin111
approved these changes
Feb 21, 2026
Member
davin111
left a comment
davin111
left a comment
There was a problem hiding this comment.
도움이 안되겠지만 무지성 approve 일단 하겠습니다..! 밖이라 제대로 리뷰는 못했습니다
Member
|
기존과 유의미하게 달라지는 걸 의도하시는 부분이 있을지 별개로 궁금하네요~ |
Member
Author
|
ecr -> ocir |
eastshine2741
approved these changes
Feb 28, 2026
| .build() | ||
| sesClient.sendEmail(request).await() | ||
|
|
||
| awaitOciCall { handler -> emailClient.submitEmail(request, handler) } |
Contributor
There was a problem hiding this comment.
OCI SDK는 리턴타입이 Future라서 논블로킹으로 쓰려면 awaitOciCall 으로 감싸야 하는구나,, 굿굿
| implementation("com.wafflestudio.spring:spring-boot-starter-waffle:2.0.0") | ||
| implementation("com.oracle.oci.sdk:oci-java-sdk-objectstorage:3.80.1") | ||
| implementation("com.oracle.oci.sdk:oci-java-sdk-emaildataplane:3.80.1") | ||
| implementation("com.oracle.oci.sdk:oci-java-sdk-common-httpclient-jersey3:3.80.1") |
Contributor
There was a problem hiding this comment.
이건 어디에 쓰는 라이브러리야? 우리 레포에서 import해서 쓰지는 않는 것 같아서
Member
Author
There was a problem hiding this comment.
https://github.com/oracle/oci-java-sdk?tab=readme-ov-file#changes-introduced-in-oci-java-sdk-3xy
라이브러리에서 http 클라이언트를 jersey나 jersey3로 수동으로 넣어줘야 한다고 나와있어
asp345
force-pushed
the
feature/oci-migration
branch
from
43862f3 to
e1d295e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev 배포까지 완료했습니다
snutt-ev 및 spring-waffle 변경사항도 확인 부탁드려요
wafflestudio/spring-waffle#15
wafflestudio/snutt-ev#134