-
Notifications
You must be signed in to change notification settings - Fork 3
[WC-59] feat : LoadingProvider 구현 및 적용 #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
younoah
wants to merge
7
commits into
develop
Choose a base branch
from
wc-59/feat/LoadingProvider
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
58f7fe9
feat : LadingProvider 구현
younoah 4c25003
feat: HomePage에 LoadingProvider 적용
younoah 4c262a6
feat: LoginPage에 LoadingProvider 적용
younoah 5daf2da
refactor: 사용하지 않는 컴포넌트 삭제
younoah 0b7ff86
feat : SignUpPage에 LoadingProvider 적용
younoah e020b71
Merge branch 'develop' of https://github.com/waffle-card/client into …
younoah 863f8b8
refactor : 초기값 간결하게 수정
younoah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import React, { createContext, useContext, useState } from 'react'; | ||
| import { Spinner } from '@/components'; | ||
|
|
||
| const LoadingDispatchContext = createContext<(loading: boolean) => void>(() => { | ||
| return; | ||
| }); | ||
|
|
||
| const LoadingStateContext = createContext(false); | ||
|
|
||
| interface LoadingProviderProps { | ||
| children: React.ReactElement | React.ReactElement[]; | ||
| } | ||
|
|
||
| export const LoadingProvider = ({ children }: LoadingProviderProps) => { | ||
| const [loading, setLoading] = useState<boolean>(false); | ||
|
|
||
| return ( | ||
| <LoadingStateContext.Provider value={loading}> | ||
| <LoadingDispatchContext.Provider value={setLoading}> | ||
| {children} | ||
| <Spinner loading={loading} /> | ||
| </LoadingDispatchContext.Provider> | ||
| </LoadingStateContext.Provider> | ||
| ); | ||
| }; | ||
|
|
||
| export const useLoadingState = () => useContext(LoadingStateContext); | ||
| export const useLoadingDispatch = () => useContext(LoadingDispatchContext); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그럼 Spinner컴포넌트는
</ModalsProvider>여기에
</LoadingProvider>항상 있는 거고 필요한 페이지에서 true, false해서 보여지고 안보여지게 하는 거 맞죠??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 리뷰해놓고 제출을 안하고있었네요 ㅠㅠㅋㅋ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yyoooon
Spinner 컴포넌트
</LoadingProvider>에서만 관리해여!!