Added implementation of Euler's totient function#6
Open
ipsin wants to merge 1 commit intowackywendell:masterfrom
Open
Added implementation of Euler's totient function#6ipsin wants to merge 1 commit intowackywendell:masterfrom
ipsin wants to merge 1 commit intowackywendell:masterfrom
Conversation
|
The comment on lines 455-456 describes the function incorrectly, although as far as I can tell the actual implementation is correct. The totient function counts all the numbers from 1 to n that are coprime with n, not just the primes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For anyone working in number theory Euler's totient function can be useful, and I thought it might make a welcome addition to your library. I understand this was unsolicited feature, so no worries if you choose not to incorporate it.
Thanks for your time.