Draft
Conversation
Owner
|
Thank you for starting the work on this! I don't have time to look over your changes at the moment, so it's probably going to be a while before I can give you proper feedback, sorry. |
Owner
|
Sorry for the long silence. I don't think I will get to this in the foreseeable future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So i got unpack part work on windows without wsl. I had to bump mypy so typed ast uploads normally, 1.4.3 for some reason never worked for anybody on windows. Yet on extract i get
AssertionError: no supported RAAS initializer found sys:1: RuntimeWarning: coroutine 'extract_layer' was never awaited, so i'll leave it here and you will take a look, maybe i missed something.Also changed logic of path a bit, since we give full path for HLP why not the same for main game?
Poetry version must be 1.30 or higher