Skip to content

Fontsize changes #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
silviapfeiffer wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Fontsize changes #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4219,6 +4219,8 @@ manner suiting the user.</p>
<li>
<p>Apply the terms of the CSS specifications to |regionNode| within the following constraints,
thus obtaining a CSS box |box| positioned relative to an initial containing block:</p>
<p class="note">The CSS specification application may make changes to a number of variables,
including |lineHeight|.</p>
Copy link
Contributor

@nigelmegitt nigelmegitt Apr 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silviapfeiffer am I right in thinking that those changes do not then modify the height of a region by changing the value of lines ? If so, I really think this needs to be stated, otherwise people might assume that the region has enough size to fit some number of lines but then after applying CSS to change lineHeight, find that it does not.

Copy link
Member Author

@silviapfeiffer silviapfeiffer Apr 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been there, see #371 (comment) , which is why we added this sentence. The CSS specification can change all those things including the height of the region.

Copy link
Contributor

@nigelmegitt nigelmegitt Apr 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we have! Without wanting to go round in circles, as noted at #371 (comment) adjusting the CSS line height does not affect the value of lines because there seems to be no step that goes back to modify it. If there actually is a step, then it is non-obvious and it would be helpful to point to it in this note, but if there is indeed no such step (and we don't add one), then that also would be worth stating in this note.

Copy link
Member Author

@silviapfeiffer silviapfeiffer Apr 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lines does not get changed, but the height of the region might because the lineHeight does. What would you like me to add? I'm very confused!

Copy link
Contributor

@nigelmegitt nigelmegitt Apr 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no mechanism for the height of the region to change based on lineHeight changing though, unless I've missed it? §7.1 Processing Model, bullet 12 step 1, bullet 2, sets lineHeight and regionHeight and derives the one time value lines. Then two bullets later the top is calculated before any CSS settings have been applied. Effectively at this point there is a fixed height.

Then in bullet 12 step 2, there's the note introduced here that says that lineHeight might be modified by CSS specification application. How is the region height then recalculated?

Side-note: I couldn't find any spec text that maps the CSS line-height value to lineHeight.

I'm reading the text "Let x be y" in an ES6-ish way, i.e. that the value of x is bound immediately and not re-evaluated whenever it is used.

So, IF my reasoning here is correct, then I'm asking for a sentence to be added to say that even if lineHeight is changed due to CSS, the height of the region is not recalculated. OR, if my reasoning is incorrect (and please do explain), then add something like "which modifies the height of the region via XXX" where XXX is a pointer to a spec section or algorithm.

<ol>
<li><p>No style sheets are associated with |regionNode|. (The regionNodes are subsequently
restyled using style sheets after their boxes are generated, as described below.)</p></li>
Expand Down
2 changes: 2 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4520,6 +4520,8 @@ <h3 class="heading settled algorithm" data-algorithm="Processing model" data-lev
<li>
<p>Apply the terms of the CSS specifications to <var>regionNode</var> within the following constraints,
thus obtaining a CSS box <var>box</var> positioned relative to an initial containing block:</p>
<p class="note" role="note">The CSS specification application may make changes to a number of variables,
including <var>lineHeight</var>.</p>
<ol>
<li>
<p>No style sheets are associated with <var>regionNode</var>. (The regionNodes are subsequently
Expand Down