Merged
Conversation
youennf
force-pushed
the
introduce-mediastreamtrackhandle
branch
from
4de6e61 to
67b8e42
Compare
youennf
force-pushed
the
introduce-mediastreamtrackhandle
branch
from
67b8e42 to
2d5d00d
Compare
jan-ivar
requested changes
Dec 18, 2025
Member
jan-ivar
left a comment
jan-ivar
left a comment
There was a problem hiding this comment.
I'd prefer if we start with a strong reference to simplify.
Contributor
|
Without having thought about it too much, it seems simpler to assume that a MediaStreamTrackHandle has a strong reference to its MediaStreamTrack; weak references are a bit harder to reason about. We should identify an use case where this is an issue before making things more complex. |
jan-ivar
approved these changes
Jan 8, 2026
youennf
commented
Jan 15, 2026
youennf
commented
Jan 15, 2026
jan-ivar
reviewed
Jan 15, 2026
guidou
approved these changes
Jan 15, 2026
github-actions bot
added a commit
that referenced
this pull request
Jan 15, 2026
SHA: dfaaaaa Reason: push, by guidou Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #116
Preview | Diff